SmmPasswordHandler function has Improper Return Status (Bugzilla Bug 4644)

[tianocore-issues]

This issue was created automatically with bugzilla2github

Bugzilla Bug 4644

Date: 2024-01-17T01:47:16+00:00
From: tabassum.yasmin
To: unassigned <>
CC: @lgao4

Last updated: 2024-01-30T21:48:30+00:00

[tianocore-issues]

Comment 22373

Date: 2024-01-17 01:47:16 +0000
From: tabassum.yasmin

• Industry Specification: ---
• Release Observed: edk2-stable202305
• Releases to Fix: edk2-stable202305
• Target OS: ---
• Bugzilla Assignee(s): unassigned <>

The CommBufferSize is copied into a local variable. This is good, however, if the size is less than the header a
status of EFI_SUCCESS is returned. This seems like it should be returning something other than success as
there is clearly an error within the commbuffer length

code snippet below
TempCommBufferSize = *CommBufferSize;
PasswordLen = 0;
if (TempCommBufferSize < sizeof (SMM_PASSWORD_COMMUNICATE_HEADER)) {
DEBUG ((DEBUG_ERROR, "SmmPasswordHandler: SMM communication buffer size invalid!\n"));
return EFI_SUCCESS --> we dont have return success always -proper error handling is needed.

[tianocore-issues]

Comment 22464

Date: 2024-01-30 21:48:30 +0000
From: @lgao4

[email protected]: please work on it.