SmmPasswordHandler Failure to clear Password Data (Bugzilla Bug 4646)

[tianocore-issues]

This issue was created automatically with bugzilla2github

Bugzilla Bug 4646

Date: 2024-01-17T01:54:43+00:00
From: tabassum.yasmin
To: tabassum.yasmin
CC: @lgao4

Last updated: 2024-01-30T21:47:41+00:00

[tianocore-issues]

Comment 22375

Date: 2024-01-17 01:54:43 +0000
From: tabassum.yasmin

• Industry Specification: ---
• Release Observed: edk2-stable202305
• Releases to Fix: edk2-stable202305
• Target OS: ---
• Bugzilla Assignee(s): tabassum.yasmin

SMM_PASSWORD_FUNCTION_SET_PASSWORD
In the case SMM_PASSWORD_FUNCTION_SET_PASSWORD, the new and old password are copied into a local
variable SmmCommunicateSetPassword. Whether the password meets all checks and reaches the end of the
case or it hits a goto EXIT statement (not shown in snippet), SmmCommunicateSetPassword is not zeroed

code snippet below

case SMM_PASSWORD_FUNCTION_SET_PASSWORD:
…
CopyMem (&SmmCommunicateSetPassword, SmmFunctionHeader + 1, sizeof(SmmCommunicateSetPassword));
…
if (PasswordLen == 0) {
Status = SavePasswordToVariable (UserGuid, NULL, 0);
} else {
Status = SavePasswordToVariable (UserGuid, SmmCommunicateSetPassword.NewPassword, PasswordLen

• 1);
  }
  break;

[tianocore-issues]

Comment 22462

Date: 2024-01-30 21:47:41 +0000
From: @lgao4

[email protected]: please work on it.