Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8 snapshot server not available anymore #13906

Closed
1 task done
m1ga opened this issue Sep 9, 2023 · 2 comments
Closed
1 task done

v8 snapshot server not available anymore #13906

m1ga opened this issue Sep 9, 2023 · 2 comments
Labels
bug needs triage This issue hasn't been reviewed by maintainers

Comments

@m1ga
Copy link
Contributor

m1ga commented Sep 9, 2023

I have searched and made sure there are no existing issues for the issue I am filing

  • I have searched the existing issues

Description

The old http://v8-snapshot.appcelerator.com/ server is not available anymore that served v8 snapshots to Mac/Windows machines when building the SDK for Android.

SDK location:

console.log('Attempting to request snapshot...');
const snapshotUrl = 'http://v8-snapshot.appcelerator.com'; // TODO: Migrate to Github Artifacts once ready
const packageJsonData = await loadPackageJson();
const requestOptions = {
body: {
v8: packageJsonData.v8.version,
script: rollupFileContent
},
json: true
};
const snapshotId = await request.post(snapshotUrl, requestOptions);
// Request generated snapshot from server using `snapshotId` obtained from server above.
const MAX_ATTEMPTS = 20; // Time-out after two minutes.
let attempts;
for (attempts = 1; attempts <= MAX_ATTEMPTS; attempts++) {
const response = await request.get(`${snapshotUrl}/snapshot/${snapshotId}`, {
simple: false,
resolveWithFullResponse: true
});

We are still at v8 8.8.278.17 (Ti 10.1.1.GA) because of a bug in 9.4 (#13395). I've fixed 9.4 (tidev/v8_titanium#55) a year ago but the build action doesn't work anymore.

v8 8.8.278.17 download:
https://github.com/tidev/v8_titanium/releases/tag/v8.8.278.17
but I'm not sure if that is the same as the snapshots from the v8-snapshot server.

Expected Behavior

downloading a snapshot

Actual behavior

failing after a few attempts

Reproducible sample

go into android/titanium and run node -e "require('./libv8-services').createSnapshotThenExit()"

Steps to reproduce

Platform

Android

SDK version you are using

12.3.0

Alloy version you are using

No response

@m1ga m1ga added bug needs triage This issue hasn't been reviewed by maintainers labels Sep 9, 2023
@cb1kenobi
Copy link
Contributor

Snapshot server is back! https://github.com/tidev/v8-snapshot-www

@cb1kenobi
Copy link
Contributor

Fix #13907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs triage This issue hasn't been reviewed by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants