Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Update v8 #14143

Open
1 task done
m1ga opened this issue Nov 11, 2024 · 1 comment
Open
1 task done

Android: Update v8 #14143

m1ga opened this issue Nov 11, 2024 · 1 comment
Labels
feature needs triage This issue hasn't been reviewed by maintainers

Comments

@m1ga
Copy link
Contributor

m1ga commented Nov 11, 2024

I have searched and made sure there are no existing issues for the issue I am filing

  • I have searched the existing issues

Description

I've tested https://github.com/tidev/v8_titanium/releases/tag/v9.4.146.16 again and I don't have any issue with it. We had this issue: #13395

but I've tested it with 12.6.0 again and compiled a module with it and used it with 12.5.1.GA and I didn't see the crash. Maybe we should give it another try and see if it works.

I did patch the old issue and had a working build: tidev/v8_titanium#55 but that action doesn't run anymore so I can't build it anymore :( This was the fix https://github.com/tidev/v8_titanium/pull/55/files#diff-4f2f329447fc899a9eadda6a27ac58bbb97ef773991b42367e35c73a15b5adcd but it looks like we don't need it. Android 14, Pixel 9 Pro.

Thinks we should do:

  • test v9.4 (build modules, build apps, build hyperloop, see if modules work in older Ti SDK version)
        "v8": {
               "version": "9.4.146.16",
                "mode": "release",
               "integrity": "sha512-847cJy3cPwIBEE57UdaexZjvnNbzgoW7kSr8cGn1unp0jtXBAitGbfJl+t4Ts1nUheWQWDZdbuCTiLqdmLDolA=="
        },
  • get the action to run again? the whole v8 build system change a lot and I wasn't able to get it running again. It would help us in the future to build new version of course

Solution

Alternatives

No response

Platforms

Android

@m1ga m1ga added feature needs triage This issue hasn't been reviewed by maintainers labels Nov 11, 2024
@AbdullahFaqeir
Copy link
Contributor

@m1ga and definitely this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature needs triage This issue hasn't been reviewed by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants