Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure gitvote #326

Closed
6 of 7 tasks
justaugustus opened this issue Apr 26, 2024 · 30 comments · Fixed by #330
Closed
6 of 7 tasks

Configure gitvote #326

justaugustus opened this issue Apr 26, 2024 · 30 comments · Fixed by #330
Assignees

Comments

@justaugustus
Copy link
Member

justaugustus commented Apr 26, 2024

cc: @anajsana

@justaugustus
Copy link
Member Author

Testing gitvote, now that #327 has merged:
/vote

Copy link

git-vote bot commented Apr 27, 2024

Something went wrong while processing the configuration file:

profiles.default.allowed_voters.teams: invalid type: string "gitvote-steering", expected a sequence at line 8 column 14

@justaugustus
Copy link
Member Author

Merged #328 to fix #326 (comment).

Let's try this again...
/vote

Copy link

git-vote bot commented Apr 27, 2024

Vote created

@justaugustus has called for a vote on Configure gitvote (#326).

The members of the following teams have binding votes:

Team
@todogroup/gitvote-steering

Non-binding votes are also appreciated as a sign of support!

How to vote

You can cast your vote by reacting to this comment. The following reactions are supported:

In favor Against Abstain
👍 👎 👀

Please note that voting for multiple options is not allowed and those votes won't be counted.

The vote will be open for 28days. It will pass if at least 67% of the users with binding votes vote In favor 👍. Once it's closed, results will be published here as a new comment.

@justaugustus
Copy link
Member Author

/check-vote

Copy link

git-vote bot commented Apr 27, 2024

Vote status

So far 0.00% of the users with binding vote are in favor (passing threshold: 67%).

Summary

In favor Against Abstain Not voted
0 0 0 4

Binding votes (0)

User Vote Timestamp
@annania Pending
@gkunz Pending
@BrittanyIstenes Pending
@nikpete Pending

Non-binding votes (1)

User Vote Timestamp
justaugustus In favor 2024-04-27 8:05:51.0 +00:00:00

@justaugustus
Copy link
Member Author

justaugustus commented Apr 27, 2024

The /check-vote has results I was not expecting:

Screenshot 2024-04-27 at 04 09 51
  • I was not recognized as a binding vote
  • The Not Voted column expects 4 voters, though the membership count of @todogroup/gitvote-steering is currently 6, which means it's also excluded @ashleywolf

Why this is happening

If you look at team membership, you'll notice that Ashley and I are listed as maintainers, not members:

Screenshot 2024-04-27 at 04 14 25 Screenshot 2024-04-27 at 04 14 45 Screenshot 2024-04-27 at 04 15 02

If we look at org membership, you'll see that Ashley and I are the only Steering Committee members that are also organization owners (which automatically elevates us to maintainer for any GitHub team we hold membership in):

Screenshot 2024-04-27 at 04 17 03 Screenshot 2024-04-27 at 04 17 24

I'll discuss this cleanup separately, and in the context of #106, but will push a fix to the gitvote config in #329.

@justaugustus
Copy link
Member Author

/cancel-vote

Copy link

git-vote bot commented Apr 27, 2024

Vote cancelled

@justaugustus has cancelled the vote in progress in this issue.

@justaugustus
Copy link
Member Author

Retrying the vote, now that #329 has merged:
/vote

Copy link

git-vote bot commented Apr 27, 2024

Vote created

@justaugustus has called for a vote on Configure gitvote (#326).

The members of the following teams have binding votes:

Team
@todogroup/gitvote-steering

Non-binding votes are also appreciated as a sign of support!

How to vote

You can cast your vote by reacting to this comment. The following reactions are supported:

In favor Against Abstain
👍 👎 👀

Please note that voting for multiple options is not allowed and those votes won't be counted.

The vote will be open for 28days. It will pass if at least 67% of the users with binding votes vote In favor 👍. Once it's closed, results will be published here as a new comment.

@justaugustus
Copy link
Member Author

/check-vote

Copy link

git-vote bot commented Apr 27, 2024

Vote status

So far 16.67% of the users with binding vote are in favor (passing threshold: 67%).

Summary

In favor Against Abstain Not voted
1 0 0 5

Binding votes (1)

User Vote Timestamp
justaugustus In favor 2024-04-27 8:36:32.0 +00:00:00
@annania Pending
@ashleywolf Pending
@gkunz Pending
@BrittanyIstenes Pending
@nikpete Pending

@justaugustus
Copy link
Member Author

Ashley and I are included as binding with that config fix!

Screenshot 2024-04-27 at 04 37 43

@gkunz
Copy link
Contributor

gkunz commented Apr 27, 2024

/check-vote

Copy link

git-vote bot commented Apr 27, 2024

Votes can only be checked once a day.

@gkunz
Copy link
Contributor

gkunz commented Apr 27, 2024

Votes can only be checked once a day.

lazy bot! 🤖

@justaugustus
Copy link
Member Author

Updating the pass threshold to simple majority (51%) will close this issue out: #330

Copy link

git-vote bot commented May 4, 2024

Vote status

So far 28.57% of the users with binding vote are in favor (passing threshold: 67%).

Summary

In favor Against Abstain Not voted
2 0 0 5

Binding votes (2)

User Vote Timestamp
justaugustus In favor 2024-04-27 8:36:32.0 +00:00:00
gkunz In favor 2024-04-27 9:43:28.0 +00:00:00
@lhawthorn Pending
@annania Pending
@ashleywolf Pending
@BrittanyIstenes Pending
@nikpete Pending

Copy link

git-vote bot commented May 11, 2024

Vote status

So far 28.57% of the users with binding vote are in favor (passing threshold: 67%).

Summary

In favor Against Abstain Not voted
2 0 0 5

Binding votes (2)

User Vote Timestamp
gkunz In favor 2024-04-27 9:43:28.0 +00:00:00
justaugustus In favor 2024-04-27 8:36:32.0 +00:00:00
@lhawthorn Pending
@annania Pending
@ashleywolf Pending
@BrittanyIstenes Pending
@nikpete Pending

@justaugustus
Copy link
Member Author

/cancel-vote

Copy link

git-vote bot commented May 11, 2024

Vote cancelled

@justaugustus has cancelled the vote in progress in this issue.

@lhawthorn
Copy link

Sorry to be late to the party. Do we want to reopen the vote and I can confirm whether my vote is counted and viewed as binding/non-binding?

@justaugustus
Copy link
Member Author

@lhawthorn — sure, a quick check would be good!

/vote

Copy link

git-vote bot commented May 13, 2024

Vote created

@justaugustus has called for a vote on Configure gitvote (#326).

The members of the following teams have binding votes:

Team
@todogroup/gitvote-steering

Non-binding votes are also appreciated as a sign of support!

How to vote

You can cast your vote by reacting to this comment. The following reactions are supported:

In favor Against Abstain
👍 👎 👀

Please note that voting for multiple options is not allowed and those votes won't be counted.

The vote will be open for 28days. It will pass if at least 51% of the users with binding votes vote In favor 👍. Once it's closed, results will be published here as a new comment.

@lhawthorn
Copy link

Done.

@justaugustus
Copy link
Member Author

/check-vote

Copy link

git-vote bot commented May 17, 2024

Vote status

So far 42.86% of the users with binding vote are in favor (passing threshold: 51%).

Summary

In favor Against Abstain Not voted
3 0 0 4

Binding votes (3)

User Vote Timestamp
justaugustus In favor 2024-05-13 7:08:35.0 +00:00:00
gkunz In favor 2024-05-13 7:24:23.0 +00:00:00
lhawthorn In favor 2024-05-17 6:04:59.0 +00:00:00
@annania Pending
@ashleywolf Pending
@BrittanyIstenes Pending
@nikpete Pending

@justaugustus
Copy link
Member Author

Thanks Leslie!
Validated that your vote is counted as binding now.
Screenshot 2024-05-17 at 02 22 12

/cancel-vote

Copy link

git-vote bot commented May 17, 2024

Vote cancelled

@justaugustus has cancelled the vote in progress in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants