-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notifications don't work #301
Comments
I can confirm that the notifications do work when the site is hosted on a service that supports https. (@emiqueuelito 's squash integration from #311 )
How difficult would this be to implement? I really liked the notifications when they worked. Thanks for the workaround, BTW. |
Apparently, the SSL certificate is not correct. It's really close, though. Whoever is in charge of the infrastructure got the heroku settings almost right. You can set go to https://www.tomato.es/ and ignore the warnings. The notifications work there. |
Thank you for the information and workaround. Excellent work!
…On Fri, Jul 5, 2019, 9:10 AM Felipe Rodrigues ***@***.***> wrote:
Apparently, the SSL certificate is not correct. It's really close, though.
Whoever is in charge of the infrastructure got the heroku settings almost
right. You can set go to https://www.tomato.es/ and ignore the warnings.
The notifications work there.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#301?email_source=notifications&email_token=ABOBEKM52V344TA5H6PGJEDP55I4JA5CNFSM4EFRJWJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZJTWNA#issuecomment-508771124>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABOBEKLGFZL2HBPRZ3WZRZ3P55I4JANCNFSM4EFRJWJA>
.
|
I would like to add that with current Firefox (68.0) notifications stopped working as well. Same reason - no https, no notification permissions. I'm using the standard heroku certificate now and added an exception, but maybe it would be a good idea to use a letsencrypt certificate? |
I guess that the latest version of Chrome (62.0.3202.94) doesn't support notifications from unsafe sources, that is non-HTTPS sites.
The short term solution would be to add a note in the settings section to explain how to workaround this deprecation. See https://sites.google.com/a/chromium.org/dev/Home/chromium-security/deprecating-powerful-features-on-insecure-origins.
The long term solution would be to update the app to support HTTPS.
The text was updated successfully, but these errors were encountered: