Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML 1.0.0-rc2? #750

Closed
6 tasks done
ChristianSi opened this issue Jun 22, 2020 · 12 comments
Closed
6 tasks done

TOML 1.0.0-rc2? #750

ChristianSi opened this issue Jun 22, 2020 · 12 comments

Comments

@ChristianSi
Copy link
Contributor

ChristianSi commented Jun 22, 2020

As v1.0.0-rc.1 was published more than 2.5 months ago and various issues have been discovered and (partially) addressed since than, I propose it's time to proceed to publishing v1.0.0-rc.2 – which might then, if we're lucky, be promoted to 1.0 Final after two more months or so.

Prior to tagging and announcing RC 2, I think the following actions are needed:


These issues should be addressed as well, but probably need not block a new RC:

@marzer
Copy link
Contributor

marzer commented Jun 22, 2020

Re #668: I took a look at the toml.tmbundle repo and it looks like abandonware at this point. All of their repos do, actually. Lots of PRs waiting to be merged with very little activity from the maintainers. Is this really where github gets their syntax highlighting juju from??

Edit: Yes :(

@pradyunsg
Copy link
Member

pradyunsg commented Jun 24, 2020

@ChristianSi Thanks for filing this! I've taken the liberty of editing the issue description, to use it as a checklist for triage.

I actually think that nearly all the changes flagged since 1.0.0-rc1 have been extremely trivial, and that we can just hop to 1.0 directly. The only blocker to us doing so is #585, which, well, is 1-weekend-of-work away from completion. :)

@ChristianSi
Copy link
Contributor Author

ChristianSi commented Jun 24, 2020

@pradyunsg Wow, that was a quicker and more thorough reaction than I could have hoped for!

Since the changes since RC 1 went beyond mere typofixes, my own inclination would be NOT to jump to 1.0 final immediately, but to release an RC 2 first. If nothing (or only typos or postponable things) comes up, it could be promoted to 1.0 final after (at least) 4 weeks. What do others think?

@pradyunsg
Copy link
Member

Hmm... I think that'll work well actually.

It's probably a good idea to run through do-a-release at least once before 1.0.0 (since that's changed with the new website) and I'll also get a bit more time to tackle #585. Consider me convinced that an 1.0.0-rc2 is a good idea. :)

@pradyunsg pradyunsg changed the title Publish Release Candidate 2 TOML 1.0.0-rc2? Jun 24, 2020
@ChristianSi
Copy link
Contributor Author

What's the status of this? Of all the tracked issues, only #685 is still open, as far as I can tell. I believe that one just needs a maintainer decision, then it could be closed quickly and the RC released...

@pradyunsg
Copy link
Member

I'd like to add in #759 as well.

@ChristianSi
Copy link
Contributor Author

Just a quick reminder that this needs to be released. #685 is still open, but it could be closed quickly and is not a blocker in my mind.

@ChristianSi
Copy link
Contributor Author

What's the status of this? Any hopes of an upcoming release?

@pradyunsg
Copy link
Member

I'm gonna be optimistic, and say that I'll do it over the weekend. :)

@ChristianSi
Copy link
Contributor Author

Will we see an August release?

@pradyunsg
Copy link
Member

Thanks for the nudge @ChristianSi!

I got distracted by automating the release process. 😅 On the plus since, the effort needed to make releases is super low now, now that I actually finished #764, so I have fewer reasons to be slow about this. :)

Will we see an August release?

Yes. Once #765 merges (inputs+reviews welcome on that!), I'll cut the release.

@pradyunsg
Copy link
Member

Done! https://github.com/toml-lang/toml/releases/tag/1.0.0-rc.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants