Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Video Attributes #209

Open
cesaregarza opened this issue Jun 16, 2023 · 1 comment
Open

Feature Request: Video Attributes #209

cesaregarza opened this issue Jun 16, 2023 · 1 comment

Comments

@cesaregarza
Copy link

wagtailmedia has been excellent to use and I'm a huge fan, the only thing I'm yearning for a little bit is the ability to specify attributes. Rather than using gifs, I've been using H264/Webm videos to display animations created with manim. However, the lack of ability to specify loop directly is a minor inconvenience. I figured I'd put this feature request in as it might be helpful to others as well. Thanks for the awesome extension!

@zerolab
Copy link
Member

zerolab commented Jun 16, 2023

@cesaregarza it would be great to get a sense of how you're using it.
The only place we're prescriptive, is in the VideoChooserBlock (

def render_basic(self, value, context=None) -> str:
if not value:
return ""
if value.type != self.media_type:
return ""
return format_video_html(value)
)

You can define your own chooser block that extends VideoChooserBlock and overrides render_basic with whatever your would like.

How do you envision specifying the attributes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants