Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter by multiple blockchains in advanced search mode #753

Open
AlexTheLion123 opened this issue May 30, 2024 · 0 comments
Open

filter by multiple blockchains in advanced search mode #753

AlexTheLion123 opened this issue May 30, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request priority: P3 The lowest priority. A desired nice-to-have improvement, but can be postponed for several releases.

Comments

@AlexTheLion123
Copy link
Contributor

AlexTheLion123 commented May 30, 2024

Summary

  • User can only filter trading pairs by a single blockchain
  • See @kenkunz reply on Discord:

tl;dr - yes, but requires some UI changes to how we generate filters options.

This is possible with Typesense, but requires some changes to how we auto-generate the available filter options. Currently, we're using the "facet" results to generate the filters and counts. Once you filter by a single blockchain, the other chains are not represented in the returned facet results.

In order to fix this, I think we would need to get the unfiltered facet results to identify available options… and merge this with the filtered facet results to display proper counts.

@AlexTheLion123 AlexTheLion123 added priority: P3 The lowest priority. A desired nice-to-have improvement, but can be postponed for several releases. enhancement New feature or request labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: P3 The lowest priority. A desired nice-to-have improvement, but can be postponed for several releases.
Projects
None yet
Development

No branches or pull requests

2 participants