Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readline missing from setup.py? #3367

Open
ross-spencer opened this issue Feb 14, 2022 · 2 comments
Open

Readline missing from setup.py? #3367

ross-spencer opened this issue Feb 14, 2022 · 2 comments

Comments

@ross-spencer
Copy link

ross-spencer commented Feb 14, 2022

Trying to install this fresh on a Windows box today.

Traceback (most recent call last):
  File "C:\Users\Spencer\Apps\python\lib\runpy.py", line 197, in _run_module_as_main
    return _run_code(code, main_globals, None,
  File "C:\Users\Spencer\Apps\python\lib\runpy.py", line 87, in _run_code
    exec(code, run_globals)
  File "C:\Users\Spencer\Apps\python\Scripts\polyfile.exe\__main__.py", line 4, in <module>
  File "C:\Users\Spencer\Apps\python\lib\site-packages\polyfile\__init__.py", line 2, in <module>
    from .__main__ import main
  File "C:\Users\Spencer\Apps\python\lib\site-packages\polyfile\__main__.py", line 18, in <module>
    from .debugger import Debugger
  File "C:\Users\Spencer\Apps\python\lib\site-packages\polyfile\debugger.py", line 12, in <module>
    from .repl import ANSIColor, ANSIWriter, arg_completer, command, ExitREPL, log, REPL, SetCompleter
  File "C:\Users\Spencer\Apps\python\lib\site-packages\polyfile\repl.py", line 7, in <module>
    import readline
ModuleNotFoundError: No module named 'readline'

It looks like readline is a new requirement and isn't listed in the requirements:

polyfile/setup.py

Lines 123 to 134 in 9c2d20b

install_requires=[
'cint',
'graphviz',
'intervaltree',
'jinja2',
'kaitaistruct>=0.7',
'networkx',
'pdfminer.six', # currently just for ascii85decode
'Pillow>=5.0.0',
'pyyaml>=3.13',
'setuptools'
],

Pip version: pip 21.3.1 from C:\Users\Spencer\Apps\python\lib\site-packages\pip (python 3.9)

@ESultanik
Copy link
Collaborator

Curious, readline has been bundled with Python since at least version 3.6, and the documentation doesn't mention any restrictions with OS 🤔. We haven't had any issues on macOS or Linux, so I suspect this is a Windows issue. I'm going to try adding support for Windows via https://github.com/pyreadline3/pyreadline3

@ESultanik
Copy link
Collaborator

PolyFile v0.4.1 should now support Windows. @ross-spencer are you able to confirm that this resolved your issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants