Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing brightness value parameter #4410

Open
bieleluk opened this issue Nov 29, 2024 · 0 comments · May be fixed by #4411
Open

Missing brightness value parameter #4410

bieleluk opened this issue Nov 29, 2024 · 0 comments · May be fixed by #4411
Assignees
@bieleluk
Labels
bug Something isn't working as expected low hanging fruit Simple, quick task.

Comments

@bieleluk
Copy link
Contributor

The function set_brightness does not use use the optional brightness value parameter.

trezor-firmware/core/src/apps/management/set_brightness.py

Line 16 in 05f464f

await set_brightness()

@bieleluk bieleluk added the bug Something isn't working as expected label Nov 29, 2024
@bieleluk bieleluk self-assigned this Nov 29, 2024
@bieleluk bieleluk added the low hanging fruit Simple, quick task. label Nov 29, 2024
@bieleluk bieleluk linked a pull request Nov 29, 2024 that will close this issue
chore(core): add missing parameter to set_brightness function #4411
Open
@trezor trezor deleted a comment from flaxyaw Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bieleluk bieleluk

Labels
bug Something isn't working as expected low hanging fruit Simple, quick task.
Projects
Firmware
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core): add missing parameter to set_brightness function trezor/trezor-firmware
1 participant
@bieleluk