Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mined UTXOs not included in default Coin Control #14270

Closed
Lemonexe opened this issue Sep 11, 2024 · 3 comments · Fixed by #16077
Closed

Mined UTXOs not included in default Coin Control #14270

Lemonexe opened this issue Sep 11, 2024 · 3 comments · Fixed by #16077
Assignees
Labels
bitcoin Bitcoin related bug Something isn't working as expected

Comments

@Lemonexe
Copy link
Contributor

Lemonexe commented Sep 11, 2024

Describe the bug
When creating a Send transaction with default Coin Control settings, I cannot send all my funds - mined UTXOs are not included. I have to open manual Coin Control and check the mined UTXOs in order to send them.

Tested only on regtest.

Info:

  • Remembered Wallet: no
  • Suite Version: web on production, desktop on develop
  • OS: Ubuntu 24.04
  • Bridge: 2.0.33
  • Firmware Version: T2T1, 2.8.1

How to reproduce
Steps to reproduce the behavior:

  1. Use trezor-user-env regtest
  2. In Suite, create regtest account no. 1
  3. Send some amount to the regtest address
  4. Mine some blocks at the regtest address
  5. Create another regtest account no. 2
  6. Open Send from regtest account no. 1
  7. Send max
  8. See that it is not the full amount! 🐛
    open Coin Control and see that mined UTXOs are not included by default, only received UTXOs are included

Expected behavior
When I don't interact with Coin Control settings, send max should include all UTXOs, including the mined.

Screenshots
In the video I have some regtest UTXOs that were recieved, and some that were mined (those are always 25).
mined_regtest.webm

@Lemonexe Lemonexe added bug Something isn't working as expected bitcoin Bitcoin related labels Sep 11, 2024
@github-project-automation github-project-automation bot moved this to 🎯 To do in Issues Suite Sep 11, 2024
@MiroslavProchazka
Copy link
Contributor

MiroslavProchazka commented Dec 4, 2024

Check whether you need 100 confirmation of mined UTXO to be able to spend them. If yes, let's close it

@Lemonexe Lemonexe self-assigned this Dec 13, 2024
@peter-sanderson
Copy link
Contributor

Even if you compose transaction with coin-controll and you try to spend it, you will get
image

@peter-sanderson
Copy link
Contributor

The root issue is here: packages/utxo-lib/src/coinselect/coinselectUtils.ts:323 (usage of the filterCoinbase function)

@peter-sanderson peter-sanderson moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Dec 20, 2024
@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Issues Suite Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitcoin Bitcoin related bug Something isn't working as expected
Projects
Status: 🤝 Needs QA
Development

Successfully merging a pull request may close this issue.

3 participants