Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(e2e): Optimizes yarn install in desktop e2e test pipeline #15897

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Vere-Grey
Copy link
Contributor

Description

Based on a suggestion from @mroz22, optimizing dependency install in our pipeline

Related Issue

#15868

Screenshots:

Copy link
Member

@vdovhanych vdovhanych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the failing tests should be good, please take a look at it.

@mroz22
Copy link
Contributor

mroz22 commented Dec 17, 2024

posted a fixup. yarn focus doesn't like the --immutable flag

@Vere-Grey Vere-Grey force-pushed the feat-e2e-pipeline-yarn-focus branch from 2345677 to e4c6a6c Compare December 26, 2024 16:18
@mroz22
Copy link
Contributor

mroz22 commented Dec 27, 2024

you are going to need to list rimraf within one of the focused packages json.
https://github.com/trezor/trezor-suite/actions/runs/12505995357/job/34890242397?pr=15897#step:4:683
it is only in the root package.json now probaly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants