Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nix): pin yarn nodejs version to build input #15914

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Conversation

szymonlesisz
Copy link
Contributor

Description

yarn should use build-in nodejs

before:

[nix-shell:~/suite]$ node --version
v22.8.0
[nix-shell:~/suite]$ yarn node --version
v20.17.0
[nix-shell:~/suite]$ yarn -v
4.5.3

after:

[nix-shell:~/suite]$ node --version
v22.8.0
[nix-shell:~/suite]$ yarn node --version
v22.8.0

Copy link
Contributor

@mroz22 mroz22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any other nix-guy except Szymon anymore in Suite? I can't really test it.

@Ondra-Zik-SL
Copy link

I’m using NixOS. I have tested it, and it seems to be working as described. Is there anything specific that needs to be tested?

@mroz22
Copy link
Contributor

mroz22 commented Dec 27, 2024

lets merge it then.

@mroz22 mroz22 merged commit d0f1208 into develop Dec 27, 2024
25 checks passed
@mroz22 mroz22 deleted the fix/nixos-yarn-nodejs branch December 27, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants