feat(suite): solana staking dashboard implementation #16027

dev-pvl · 2024-12-18T15:09:31Z

Description

Implemented support for fetching Solana epoch information
Enables fetching APY data for Solana
Upgraded wallet-sdk to the latest version
Enabled unstaking and claiming functionality
Added a utility to get staking limits by network
Added a utility to get staking balances for the current network
Refactored staking components to include Solana support
Resolved minor Solana compatibility issues in components

Related Issue

Resolves #15231
Resolve #15266
Resolve #15233
Resolve #15229
Resolve #16036
Resolve #16037
Resolve #16038

Screenshots

packages/blockchain-link-types/src/common.ts

packages/suite/src/components/wallet/WalletLayout/AccountsMenu/AccountSection.tsx

packages/suite/src/support/messages.ts

suite-common/wallet-core/src/stake/stakeConstants.ts

packages/suite/src/views/wallet/staking/components/StakingDashboard/StakingDashboard.tsx

tomasklim · 2024-12-18T18:48:29Z

When staking on an account for the first time. After stake, can we show staking dashboard faster? It takes user back to the What is staking? page and then after few seconds it shows dashboard

tomasklim · 2024-12-18T18:50:55Z

~~Please show the including tokens & staking only in debug mode. For prod, just including tokens~~

tomasklim · 2024-12-18T19:35:39Z

~~@dev-pvl please run yarn dedupe, check is failing~~ ✅

tomasklim · 2024-12-18T19:46:49Z

~~@dev-pvl please add staking also to dashboard Assets, card and table~~

dev-pvl · 2024-12-20T14:12:05Z

We can display the staking dashboard more quickly when transactions are supported. Currently, checking for Solana staking relies on the existence of staking accounts. This serves as a temporary solution, but eventually, we should base the check on the transactions themselves. Once we have transactions, we can probably show the dashboard faster.

vytick · 2024-12-20T15:44:25Z

packages/blockchain-link/src/workers/solana/index.ts

            misc = {
                owner: accountInfo?.owner,
                rent: Number(rent),
-                solStakingAccounts: [],
+                solStakingAccounts: stakingData?.stakingAccounts,
+                solEpoch: stakingData?.epoch,


it feels odd to have blockchain related info (network epoch) with account related data 🤔

vytick · 2024-12-20T15:46:16Z

packages/blockchain-link/src/workers/utils.ts

    const { result: stakingAccounts } = delegations;

-    return stakingAccounts;
+    const epochInfo = await solanaClient.getEpochInfo();


this will be called for each account instead of fetching that info only once for the whole network - imo this should not be fetched nor stored with account data

You're right. Where do you think it should be fetched/stored instead?

vytick · 2024-12-20T19:14:37Z

...ents/suite/modals/ReduxModal/UserContextModal/StakeModal/StakingInfoCards/EstimatedGains.tsx

@@ -74,7 +74,15 @@ export const EstimatedGains = () => {
                    id="TR_STAKING_YOUR_EARNINGS"
                    values={{
                        a: chunks => (
-                            <TrezorLink href={HELP_CENTER_ETH_STAKING}>{chunks}</TrezorLink>
+                            <TrezorLink


whole EstimatedGains seems to be for ETH only. There are no estimations for SOL, it seems. If that is the case, can we have it renamed to smthng like EthEstimatedGains or make it universal?

If the code used actually is universal, can we rename it not to use eth in it?

As far as I know, we have EstimatedGains for Solana. Refactored component a bit to avoid this confusion 0c3a403

vytick · 2024-12-20T19:19:35Z

packages/suite/src/utils/suite/ethereumStaking.ts

    UNSTAKE_INTERCHANGES,
    WALLET_SDK_SOURCE,
    UNSTAKING_ETH_PERIOD,
 } from '@suite-common/wallet-constants';
 import type { NetworkSymbol } from '@suite-common/wallet-config';
-import { getEthereumEstimateFeeParams, isPending, sanitizeHex } from '@suite-common/wallet-utils';
+import {


If this file is not related only to eth, can we have everything renamed not to use eth in it?

I belive it is related to eth. Created a separate utils file for common staking functions. 0c3a403

vytick · 2024-12-20T20:58:55Z

packages/suite/src/views/dashboard/AssetsView/AssetCard/AssetCard.tsx

@@ -127,10 +128,16 @@ export const AssetCard = ({
        selectAssetAccountsThatStaked(state, stakingAccountsForAsset),
    );

+    // TODO: remove this logic when Solana staking is available


we can maybe have selector for this logic and reuse it

added selector, 4460aff

vytick · 2024-12-20T21:02:44Z

...s/suite/src/views/wallet/staking/components/StakingDashboard/components/EmptyStakingCard.tsx

@@ -30,7 +30,6 @@ export const EmptyStakingCard = () => {
    const { isStakingDisabled, stakingMessageContent } = useMessageSystemStaking();

    const ethApy = useSelector(state => selectPoolStatsApyData(state, account?.symbol));


pls rename to apy or smthng like that, if there can be solapy as well

done, 0c3a403

vytick · 2024-12-20T21:03:39Z

...s/suite/src/views/wallet/staking/components/StakingDashboard/components/EmptyStakingCard.tsx

@@ -30,7 +30,6 @@ export const EmptyStakingCard = () => {
    const { isStakingDisabled, stakingMessageContent } = useMessageSystemStaking();

    const ethApy = useSelector(state => selectPoolStatsApyData(state, account?.symbol));
-    // TODO: calc solApy

    const dispatch = useDispatch();
    const openStakingEthInANutshellModal = () => {


should here be only eth and no sol?

renamed as well, 0c3a403

I dont see it renamed @dev-pvl

dev-pvl · 2024-12-23T15:02:09Z

I believe the useStakeEthForm, useUnstakeEthForm, and useClaimEthForm hooks, as well as Ethereum-specific components, should be refactored to support both Ethereum and Solana. However, this would likely require significant work, so it might be better to address it in a separate PR. For now, prioritizing feature support seems more practical, as we discussed previously. Wdyt, @tomasklim?

dev-pvl requested review from MiroslavProchazka, marekrjpolak and mroz22 as code owners December 18, 2024 15:09

dev-pvl force-pushed the feat/solana-staking-dashboard-implementation branch from 2949fa0 to 7e7e26f Compare December 18, 2024 15:11

tomasklim requested changes Dec 18, 2024

View reviewed changes

tomasklim requested review from martykan and vytick December 18, 2024 16:34

dev-pvl force-pushed the feat/solana-staking-dashboard-implementation branch from 7e7e26f to 7ce2999 Compare December 18, 2024 17:02

martykan mentioned this pull request Dec 19, 2024

feat(suite): solana staking dashboard implementation #16044

Draft

vytick reviewed Dec 20, 2024

View reviewed changes

dev-pvl added 7 commits December 23, 2024 15:34

feat(blockchain-link): add Solana epoch info call and upgrade SDK

77917ab

feat(suite): add getAssets call to fetch Solana APY data

66ea09c

chore(suite): add Solana epoch info to account, upgrade SDK to latest

394f3a6

feat(suite): add utility to get staking limits by network

6a42466

feat(suite): implement solana staking dashboard

6249141

feat(suite): add solana unstaking and claiming methods

e58f97b

feat(suite): include Solana staking balance in assets

bf16abe

dev-pvl force-pushed the feat/solana-staking-dashboard-implementation branch from 74cd1b0 to bf16abe Compare December 23, 2024 13:35

dev-pvl added 2 commits December 23, 2024 16:40

fixup! feat(suite): implement solana staking dashboard

0c3a403

fixup! feat(suite): include Solana staking balance in assets

4460aff

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(suite): solana staking dashboard implementation #16027

feat(suite): solana staking dashboard implementation #16027

dev-pvl commented Dec 18, 2024 •

edited by tomasklim

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading

dev-pvl commented Dec 20, 2024

vytick Dec 20, 2024

vytick Dec 20, 2024

dev-pvl Dec 23, 2024

vytick Dec 20, 2024

dev-pvl Dec 23, 2024

vytick Dec 20, 2024

dev-pvl Dec 23, 2024

vytick Dec 20, 2024

dev-pvl Dec 23, 2024

vytick Dec 20, 2024

dev-pvl Dec 23, 2024

vytick Dec 20, 2024

dev-pvl Dec 23, 2024

tomasklim Dec 25, 2024

dev-pvl commented Dec 23, 2024

		@@ -30,7 +30,6 @@ export const EmptyStakingCard = () => {
		const { isStakingDisabled, stakingMessageContent } = useMessageSystemStaking();

		const ethApy = useSelector(state => selectPoolStatsApyData(state, account?.symbol));

feat(suite): solana staking dashboard implementation #16027

Are you sure you want to change the base?

feat(suite): solana staking dashboard implementation #16027

Conversation

dev-pvl commented Dec 18, 2024 • edited by tomasklim Loading

Description

Related Issue

Screenshots

tomasklim commented Dec 18, 2024 • edited Loading

tomasklim commented Dec 18, 2024 • edited Loading

tomasklim commented Dec 18, 2024 • edited Loading

tomasklim commented Dec 18, 2024 • edited Loading

dev-pvl commented Dec 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dev-pvl commented Dec 23, 2024

dev-pvl commented Dec 18, 2024 •

edited by tomasklim

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading

tomasklim commented Dec 18, 2024 •

edited

Loading