Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some kernel arguments are not used #26

Open
huiyuxie opened this issue Aug 31, 2024 · 3 comments
Open

Some kernel arguments are not used #26

huiyuxie opened this issue Aug 31, 2024 · 3 comments
Labels
upstream Related to upstream

Comments

@huiyuxie
Copy link
Member

To keep consistency with the original code from Trixi.jl, the arguments for rhs_gpu! include initial_condition, but it is never used. Based on this, all kernel arguments should be reviewed, and we are also waiting trixi-framework/Trixi.jl#2037 to be merged.
@huiyuxie huiyuxie added the upstream Related to upstream label Aug 31, 2024
@huiyuxie
Copy link
Member Author

Once it is merged, please check the compatibility with current code.

@huiyuxie huiyuxie mentioned this issue Aug 31, 2024
Merged
@huiyuxie
Copy link
Member Author

Closed as it was resolved in #27.

@huiyuxie
Copy link
Member Author

Please update the mortar API when ready to bump Trixi.jl to version >=0.9.9, see trixi-framework/Trixi.jl#2188

@huiyuxie huiyuxie reopened this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream Related to upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huiyuxie