Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

Migrations.sol‘s upgrade() won't execute correctly #5

Open
yushih opened this issue Jul 18, 2018 · 0 comments
Open

Migrations.sol‘s upgrade() won't execute correctly #5

yushih opened this issue Jul 18, 2018 · 0 comments

Comments

@yushih
Copy link

yushih commented Jul 18, 2018

I'm not 100% about understanding the upgrade() method correctly so apologies in advance if I got this wrong. The upgrade() method looks problematic: suppose upgraded.setCompleted has the same restricted() modifier as "this" contract, then it should fail because msg.sender is the address of "this" contract which could not be upgraded.owner. So there is no way the upgrade.setCompleted call could be executed successfully.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant