From bee9b820a11d7c5011a69d17f1745ce33e4bc244 Mon Sep 17 00:00:00 2001
From: Robert <766670+rben01@users.noreply.github.com>
Date: Wed, 11 Dec 2024 03:28:00 -0500
Subject: [PATCH] Disabled default benches throughout the workspace (#2122)

* Disabled default benches throughout the workspace

See https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options for why this is necessary

* Replaced outdated `std.string.chars` with `std.string.characters`
---
 core/Cargo.toml                       | 6 +++---
 core/benches/records/countLetters.ncl | 2 +-
 git/Cargo.toml                        | 3 +++
 lsp/lsp-harness/Cargo.toml            | 3 +++
 lsp/nls/Cargo.toml                    | 1 +
 pyckel/Cargo.toml                     | 1 +
 vector/Cargo.toml                     | 7 +++++++
 wasm-repl/Cargo.toml                  | 1 +
 8 files changed, 20 insertions(+), 4 deletions(-)

diff --git a/core/Cargo.toml b/core/Cargo.toml
index 39c34617bc..335fc073b8 100644
--- a/core/Cargo.toml
+++ b/core/Cargo.toml
@@ -112,9 +112,9 @@ harness = false
 name = "arrays"
 harness = false
 
-# [[bench]]
-# name = "records"
-# harness = false
+[[bench]]
+name = "records"
+harness = false
 
 [[bench]]
 name = "serialization"
diff --git a/core/benches/records/countLetters.ncl b/core/benches/records/countLetters.ncl
index b111ac3c0c..9cbe5343af 100644
--- a/core/benches/records/countLetters.ncl
+++ b/core/benches/records/countLetters.ncl
@@ -6,5 +6,5 @@
       else
         std.record.insert "%{char}" 1 dict
     in
-    std.array.fold_left update_dict {} (std.string.chars s)
+    std.array.fold_left update_dict {} (std.string.characters s)
 }
diff --git a/git/Cargo.toml b/git/Cargo.toml
index d991a9e55a..3254a87058 100644
--- a/git/Cargo.toml
+++ b/git/Cargo.toml
@@ -4,6 +4,9 @@ description = "Git utility functions for internal use in nickel"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+bench = false
+
 [dependencies]
 anyhow.workspace = true
 gix = { workspace = true, features = ["blocking-network-client", "serde"] }
diff --git a/lsp/lsp-harness/Cargo.toml b/lsp/lsp-harness/Cargo.toml
index 920924ccd6..8a7c2812c9 100644
--- a/lsp/lsp-harness/Cargo.toml
+++ b/lsp/lsp-harness/Cargo.toml
@@ -3,6 +3,9 @@ name = "lsp-harness"
 version = "0.1.0"
 edition = "2021"
 
+[lib]
+bench = false
+
 [dependencies]
 anyhow.workspace = true
 env_logger.workspace = true
diff --git a/lsp/nls/Cargo.toml b/lsp/nls/Cargo.toml
index 1a5563728e..e7e54186ff 100644
--- a/lsp/nls/Cargo.toml
+++ b/lsp/nls/Cargo.toml
@@ -13,6 +13,7 @@ version.workspace = true
 [[bin]]
 name = "nls"
 path = "src/main.rs"
+bench = false
 
 [[bench]]
 name = "main"
diff --git a/pyckel/Cargo.toml b/pyckel/Cargo.toml
index 28c7edda95..5dc74f34c9 100644
--- a/pyckel/Cargo.toml
+++ b/pyckel/Cargo.toml
@@ -20,3 +20,4 @@ pyo3-build-config.workspace = true
 
 [lib]
 crate-type = ["cdylib", "rlib"]
+bench = false
\ No newline at end of file
diff --git a/vector/Cargo.toml b/vector/Cargo.toml
index 13b13001b7..a41bb0861a 100644
--- a/vector/Cargo.toml
+++ b/vector/Cargo.toml
@@ -9,6 +9,9 @@ keywords.workspace = true
 license.workspace = true
 repository.workspace = true
 
+[lib]
+bench = false
+
 [dependencies]
 imbl-sized-chunks = "0.1.2"
 serde.workspace = true
@@ -19,6 +22,10 @@ arbtest = "0.3.1"
 criterion = "0.5.1"
 rpds = "1.1.0"
 
+[[bench]]
+name = "array"
+harness = false
+
 [[bench]]
 name = "rpds_comparison"
 harness = false
diff --git a/wasm-repl/Cargo.toml b/wasm-repl/Cargo.toml
index 17c97cfd95..13fc027a09 100644
--- a/wasm-repl/Cargo.toml
+++ b/wasm-repl/Cargo.toml
@@ -14,3 +14,4 @@ nickel-lang-core = { workspace = true, default-features = false, features = ["re
 
 [lib]
 crate-type = ["cdylib", "rlib"]
+bench = false
\ No newline at end of file