Macro default value as variable

[VincentLanglet]

In the MacroTokenParser, there is a check that default value are constants

Twig/src/TokenParser/MacroTokenParser.php

Line 96 in ef3dbab

if (!$this->checkConstantExpression($default)) {

Which means that

{% set baz = 'hello' %}
{% macro foo(bar=baz) %}{{ bar }} {% endmacro %}

is not doable.

Is it something which could change or should it stay like this for some reasons/limitations ?

In my linter, I want to easily identify params of a macro, can I rely on the fact this is all the Token::NAME (except macro and the macro name) between {% and %} ? Or could it easily change in some futur ?

[stof]

This should stay like that. Supporting variables in default values would require defining in which scope they are resolved.

Note that PHP also enforces constant expressions in default values.

[stof]

Note that a default value being a mapping could have name tokens for the array keys. So assuming that all name tokens are used for argument names is probably not a shortcut you can take.

[VincentLanglet]

Indeed !
Thanks, I updated my PR VincentLanglet/Twig-CS-Fixer#334
It's now all the name tokens, where the previous opened bracket is (. (This will avoid {foo: 'bar'})

[stof]

wouldn't this work only for the first argument of the macro ?

[VincentLanglet]

By the previous opened bracket is (, I meant the previous opened and still opened bracket.

In {% macro(foo, bar) %}, the previous opened bracket of bar is still (.
And in {% macro(foo={1:2}, bar) %} the previous opened bracket is still (, cause { was already closed.

I keep a track of opened bracket in an array, and pop the last element when a matching closer is found.