Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly separate CI checks #61

Open
twynb opened this issue Sep 15, 2023 · 2 comments
Open

Properly separate CI checks #61

twynb opened this issue Sep 15, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@twynb
Copy link
Owner

twynb commented Sep 15, 2023

As of current, the lint CI check failing isn't actually displayed anywhere, except if you look into that specific part of the CI check.

The CI check should be separated into separate jobs for linting and testing, each of which should indeed throw a fail if it does fail.

@twynb twynb added the bug Something isn't working label Sep 15, 2023
@chubetho
Copy link
Collaborator

I think we can make CI fail if Lint fails.
Then add ruff to lint-staged in package.json

  "lint-staged": {
    "*.{vue,ts,json}": "eslint --fix",
    "*.{py,fake_ext}": "black",
    "*.{fake_ext,py}": "ruff check --fix"
  }

and update with npx simple-git-hooks so that each commit is properly formatted and linted before being pushed up.

@twynb
Copy link
Owner Author

twynb commented Sep 16, 2023

What I am suggesting is not having one CI job that runs both linting and testing, but separate jobs for linting and tests. So we still get the feedback if linting fails, but can tell if what failed is the linting or the actual tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants