Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emacs support? #125

Open
tomjridge opened this issue Mar 11, 2018 · 16 comments
Open

Emacs support? #125

tomjridge opened this issue Mar 11, 2018 · 16 comments

Comments

@tomjridge
Copy link

No description provided.

@rageandqq
Copy link
Member

Hi @tomjridge , thanks for your interest in Tandem!
Currently, we only support Neovim and Sublime Text.
While we do have plans to extend Tandem to other editors, I don't think we'll be developing an Emacs plugin anytime soon.

However, if you are interested in developing a Tandem plugin for Emacs, we'd be delighted to help out along the way and more than welcome Pull Requests.
We wrote a how-to for developing Tandem plugins. Check out our wiki: https://github.com/typeintandem/tandem/wiki/Interacting-with-the-Tandem-Agent
As long as your plugin conforms to that outline, it should work seamlessly with the Agent!

@anarcat
Copy link

anarcat commented Mar 14, 2018

@rageandqq could you clarify what the Tandem agent is exactly? i see that the neovim plugin requires the neovim Python2 client and node.js, is that how the agent works, with node.js? this repository only has Python code, so I'm a little confused regarding the node.js requirement there...

@alexjgriffith
Copy link

The crdt is run on node.js

@geoffxy
Copy link
Member

geoffxy commented Mar 14, 2018

@anarcat The Tandem agent implements all of the common functionality that all plugins need (e.g. managing peers in a session, sending messages between peers, etc.). We actually use the CRDT that powers Teletype under the hood. Since they implemented it in JavaScript, we need to take on the Node.js dependency in order to actually use it with the agent.

@jscheid
Copy link

jscheid commented Mar 15, 2018

I've got something work-in-progress here https://github.com/jscheid/tandem-emacs

It works pretty well when joining a session, hosting a session (and joining it with Sublime) seems broken in the agent?

@alexjgriffith
Copy link

@jscheid i've run into the same issue when trying to host via the command line and join via sublime. Looking at the log all I get are the following messages:

2018-03-15 00:19 INFO     Tandem UDPGateway is listening on ('', 4001).
2018-03-15 00:19 INFO     Tandem Agent has started.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.
2018-03-15 00:20 DEBUG    Received data from 192.168.0.116:60689.

@anarcat
Copy link

anarcat commented Mar 15, 2018

oh boy, how exciting! didn't expect that to happen so soon :) congrats on the author and keep it up! should we report issues there or here?

(this only makes licensing issues described in #131 even more pressing unfortuantly...)

@alexjgriffith
Copy link

@anarcat since we are not modifying their agent, and it is their agent that is communicating with the server it might be ok. Alternatively we can point it to another server.

@anarcat
Copy link

anarcat commented Mar 15, 2018 via email

@anarcat
Copy link

anarcat commented Mar 15, 2018

the license will change, so nevermind those comments :) whoohoo!

@rageandqq
Copy link
Member

@anarcat @alexjgriffith The license has been updated! See #135. Hope this quells your concerns 😄

@jscheid That's awesome! I too didn't expect this to happen so soon. What version of python3 are you running locally? We verified that the agent works with python3.6+, and handling versioning issues (and potentially rethinking how we choose, version, and distribute Tandem's dependencies) is one of the issues our team is planning to address.

@jscheid
Copy link

jscheid commented Mar 16, 2018

I have Python 3.6.4 from homebrew.

Could it be a discrepancy between the version of the agent used by the Sublime plugin and the one I'm using?

@alexjgriffith
Copy link

Does it work with the vim plugin? I have tried using the same agent for both the Emacs extension and Sublime plugin and still could not host on Emacs.

@jscheid
Copy link

jscheid commented Mar 16, 2018

It turns out Emacs hasn't quite achieved sentience yet and didn't know to send the initial buffer when hosting a session without me telling it to... it should work better now.

@kfogel
Copy link

kfogel commented Mar 19, 2018

By the way, what are the criteria for getting it listed as the (or as "an") unofficial Emacs plugin in the README and on the home page?

@anarcat
Copy link

anarcat commented Jun 26, 2018

What's the status here? It seems that the plugin haven't changed since march, does it actually work? Should Emacs be included in the list of supported clients?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants