Add support for subsequent author substitution #228
Conversation
|
This is ready to merge. |
There was a problem hiding this comment.
Please undo changes to archive files, they should be updated separately. (You can rebase on main to get the latest updates.) Thank you!
| @@ -303,6 +310,39 @@ impl<'s> TestCaseBuilder<'s> { | |||
| } | |||
| } | |||
|
|
|||
| fn extract_from_html(html: &str) -> String { | |||
There was a problem hiding this comment.
Could you implement bibliography test support on a separate PR? As is, it's harder to tell at a glance which changes were due to subsequent author substitution support and which changes were due to newly-supported bibliography tests.
| @@ -0,0 +1,85 @@ | |||
| use hayagriva::citationberg::IndependentStyle; | |||
There was a problem hiding this comment.
I do wonder if this could become a local citeproc test with the new bibliography support.
Though it'd generally be nice to have better infrastructure for non-citeproc (hayagriva YAML) tests. I wonder if we could have a nice little macro which does all of this in a less repetitive way, so we can have multiple tests in a single file.
| }); | ||
|
|
||
| for i in result.bibliography.unwrap().items { | ||
| eprintln!("{}", i.content); |
There was a problem hiding this comment.
(I also believe this should be an assertion.)
Fixes #219. Fixes #229 (as a first approximation)
Also fixes the error that affixes for bibliography layout were ignored. And updates archives.
Adds 96 tests to
citeproc-pass.txt.Still a draft until: