New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is point_set visuable #15

Open

ArtlyStyles opened this issue Dec 12, 2018 · 0 comments

ArtlyStyles commented Dec 12, 2018

I am using your code for one of my project and in general it worked very well. But I have a question I hope you can help.

In ObstacleExtractor.cpp function "groupPoints", you use the following line:

point_set.is_visible = (abs(sin_d) > sin_dp || range < prev_range);

But think it should be

point_set.is_visible = (abs(sin_d) > sin_dp || range > prev_range);

Could you please confirm?

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment