Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proguard config for Creatable #202

Open
kurtisnelson opened this issue Apr 9, 2020 · 1 comment
Open

Add proguard config for Creatable #202

kurtisnelson opened this issue Apr 9, 2020 · 1 comment

Comments

@kurtisnelson
Copy link

kurtisnelson commented Apr 9, 2020

If a scope is only instantiated via the new Creatable method, proguard will strip the Impl with the current config. As a temporary workaround, all subclasses can be kept via:

-keep class * implements motif.Creatable {
    <init>(...);
}

However long-term the solution is to use -if to pair the impl with the kept state of the interface.

@andreasnomikos
Copy link

wait didn't we add a test for this exact thing ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants