Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multilanguage installer #857

Open
bovirus opened this issue Aug 16, 2024 · 5 comments
Open

Multilanguage installer #857

bovirus opened this issue Aug 16, 2024 · 5 comments
Assignees
Labels

Comments

@bovirus
Copy link
Contributor

bovirus commented Aug 16, 2024

The app is mutlilanguage

The installer currently is mono language (English).

The installer is based on cmake/Inno Setup.

Please add to the installer the same language list that is available the GUI for,

@Feichtmeier
Copy link
Member

hi, I will deprecate the installer when I finish this #964

@bovirus
Copy link
Contributor Author

bovirus commented Nov 18, 2024

@Feichtmeier

Current version 2.4.0 is released as installer made by Inno Setup.
Why until you continue to use Inno Setup don't implement multilanguage installer?
It's easy and the app is multilanguage then installer could be better multilanguage.
What are the negative point to have multilanguage installer?

@Feichtmeier
Copy link
Member

Feichtmeier commented Nov 18, 2024

@Feichtmeier

Current version 2.4.0 is released as installer made by Inno Setup. Why until you continue to use Inno Setup don't implement multilanguage installer? It's easy and the app is multilanguage then installer could be better multilanguage. What are the negative point to have multilanguage installer?

because it looks like work and I do this all in my free time if you didnt notice and I need to prioritize my time spend on important things and this exe installer will hopefully be gone soon and I will automatically deploy musicpod (for free) to the windows store instead, no installer needed then
if you know how this would work, feel free to open a pull request

@bovirus
Copy link
Contributor Author

bovirus commented Nov 19, 2024

@Feichtmeier

Then if I make a PR with changes for Inno Setup multilanguage installe until you will enable in the future installation by MS Store could be OK and you will merge?

@Feichtmeier Feichtmeier reopened this Nov 19, 2024
@Feichtmeier
Copy link
Member

@Feichtmeier

Then if I make a PR with changes for Inno Setup multilanguage installe until you will enable in the future installation by MS Store could be OK and you will merge?

I don't know yet what your pr will look like but if your pull request passes the CI and doesn't break anything I will probably merge it in the end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants