Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secure session cookie secret #10

Open
grant-h opened this issue Oct 18, 2017 · 0 comments
Open

Secure session cookie secret #10

grant-h opened this issue Oct 18, 2017 · 0 comments
Labels
bug security

Comments

@grant-h
Copy link
Collaborator

grant-h commented Oct 18, 2017

Our session cookie secret is public in the source code. This means cookies can be arbitrarily forged. Currently, this is not an issue as cookies don't contain sensitive data, but this could change in the future. Move this secret to a DB/config only file.
@grant-h grant-h added the bug label Oct 18, 2017
grant-h pushed a commit that referenced this issue May 24, 2018
@JKomskis
Merge pull request #10 from CEN3031-SIT-WEB-APP/resumes
5d21580 
Resumes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@grant-h