Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendered QR code does not respect device pixel ratio #128

Open
uhthomas opened this issue Nov 30, 2020 · 1 comment
Open

Rendered QR code does not respect device pixel ratio #128

uhthomas opened this issue Nov 30, 2020 · 1 comment
Labels

Comments

@uhthomas
Copy link
Owner

No description provided.

@uhthomas
Copy link
Owner Author

This is because QRious renders to a canvas. There are two options to resolve this:

  1. Resize the canvas to match the new device pixel ratio on page size change.
  2. Find a different library which outputs SVGs.

The second option is my preferred solution as it means there doesn't need to be any new code to watch for changes to the viewport which also means there's likely to be bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant