-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with empty formName() and one column #347
Comments
How to reproduce the issue? In other words, post the code snippet to reproduce the issue |
|
Any suggestions on how to fix it? 😄 Throw an exception if form name is empty? |
formName() CAN return empty string! It's just a prefix for input name. With prefix name will be "MyForm[email]" (by default), without it - "email".
Always return default prefix and check this condition here. So this name will be |
Do you accept a PRs? |
I would rephrase - at the moment I only rely on PR 😄 |
@olegbaturin so will you make a PR or it was a rhetorical question? 😄 |
I'll have some time to this fix in the next week or so. |
Here you consider that Model::formName() returns not empty string. As a result input names look like "[attribute][index]" because here you consider that prefix can't be empty.
The text was updated successfully, but these errors were encountered: