Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off modification times by default #43

Open
madig opened this issue Dec 2, 2017 · 6 comments
Open

Turn off modification times by default #43

madig opened this issue Dec 2, 2017 · 6 comments

Comments

@madig
Copy link
Contributor

madig commented Dec 2, 2017

I regularly trip over this because I forget using the -m parameter, and using it won't erase the mod times already written to disk. Since a normalizer should normalize and not jot down mod times, I petition to turn it off by default.

@anthrotype
Copy link
Member

I agree. Also because the main use case for the normalizer IMO is to avoid unnecessary diffs when the UFOs are under git version control. And the modification timestamps change by definition all the time.

@miguelsousa
Copy link
Member

I'm not opposed to that change, but I'd like to hear other people's opinion first. I understand the motivation — I added the -m option and use it pretty much every time to avoid the diff as well — but the time stamps serve a real purpose: make re-normalization faster. I wished there was a way to save the mod times in a separate file which could then be git-ignored. This way we'd get its benefits without interfering with the diff.

@madig
Copy link
Contributor Author

madig commented Dec 5, 2017 via email

@anthrotype
Copy link
Member

No because layerinfo is part of the ufo source, and should not be gitignored. We can store them next to the ufo, and name the dotfile with the same name as the ufo it is normalising

@anthrotype
Copy link
Member

Or maybe in the data folder would be better (ufo3 only)

@miguelsousa
Copy link
Member

I like the data folder idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants