Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags not displaying value on first launch #118

Open
1 of 2 tasks
drekka opened this issue Sep 15, 2023 · 4 comments
Open
1 of 2 tasks

Flags not displaying value on first launch #118

drekka opened this issue Sep 15, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@drekka
Copy link

drekka commented Sep 15, 2023

We've noticed that on first launch after a fresh install of a settings app that uses Vexil, boolean flags display a toggle switch, but tapping it appears to do nothing. In actual fact the toggle is being changed, it's just the UI that is not working.

We've found that if we kill the app and restart it the toggles then work as expected and will continue to do so until we install the next version. Where upon they stop updating until we restart the app again.

Vexil version: 2.2.2
Swift version: swift-driver version: 1.75.2 Apple Swift version 5.8.1 (swiftlang-5.8.0.124.5 clang-1403.0.22.11.100)
Environment: Simulator and device.

✅ Checklist

  • If possible, I've reproduced the issue using the main branch of this package
  • I've searched for existing GitHub issues
@drekka drekka added the bug Something isn't working label Sep 15, 2023
@bok-
Copy link
Contributor

bok- commented Sep 15, 2023

Hi @drekka, this one sounds familiar, I believe we've seen it before. I will go digging through our PR history, but just to confirm, are you using UserDefaults to share your flags with your Settings app, or something custom?

Bok

@arinjoy
Copy link

arinjoy commented Sep 15, 2023

Hi @bok- , I think I've faced the same issue too and solved it this way. But mine was slightly different again maybe. Will and I both solved that way the one we faced back then.

#115 (comment)

@drekka
Copy link
Author

drekka commented Sep 18, 2023

Hi, yes we are using a shared user defaults group. I'm also sure I read a mention of this somewhere but I was unable to locate it before writing up the issue.

@drekka
Copy link
Author

drekka commented Oct 29, 2024

Coming back to this one as I'm on another client's project where some other devs have implemented Vexil. Seeing the same issue with the UI. On first launch the flag toggles do not toggle even though the flag is set in the data. Getting it reported by users and it's quite annoying so would appreciate if it could be looked into soon :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants