Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtran rnn error #2

Open
at-peter opened this issue Aug 20, 2021 · 1 comment
Open

qtran rnn error #2

at-peter opened this issue Aug 20, 2021 · 1 comment

Comments

@at-peter
Copy link

Hey guys, me again. Thanks for closing the last issue so quickly, I hope this one is just as simple. I am trying to train qtran on the LBF environment and epymarl keep crashing when I do so. There seems to be some issue with the argument args.use_rnn in the basic controller that is causing the program to fail. I am getting the following error: attribute error: 'types.SimpleNamespace' object has no attribute 'use_rnn'

I hope its not too much of a problem and look forwards to seeing this resolved :)

thanks,
Peter

@semitable
Copy link
Member

Hi Peter,

In our benchmark paper we didn't implement/run qtran, so apparently the implemented version is the original pymarl one (without our modifications of enabling/disabling RNN, parameter sharing, etc). My guess is that it should be quite simple copy these implementation details from the other algorithms and make it work.

We'd be happy to accept a pull request if you plan to make it work soon. Otherwise, me or @papoudakis can take this, but I'd expect it to be in a couple weeks if not more due to other running deadlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants