Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CCP_get_param_from_packet はマクロなので大文字にする #548

Open
meltingrabbit opened this issue Apr 16, 2023 · 2 comments
Open

CCP_get_param_from_packet はマクロなので大文字にする #548

meltingrabbit opened this issue Apr 16, 2023 · 2 comments
Assignees
@meltingrabbit
Labels
priority::medium priority medium

Comments

@meltingrabbit
Copy link
Collaborator

概要

CCP_get_param_from_packet はマクロなので大文字にする

close条件

sedしたら
@meltingrabbit meltingrabbit added the priority::medium priority medium label Apr 16, 2023
@meltingrabbit meltingrabbit self-assigned this Apr 16, 2023
@ToshiAki64
Copy link
Collaborator

CCP_get_param_from_packetは、逆にマクロから関数に変更する選択肢はないのでしょうか？

  • ほとんどのコマンドで使用しているので、コードサイズが不要に増える
  • sedで１発とはいえ、core update 時に user 側の変更が必要な点が渋い

@meltingrabbit
Copy link
Collaborator Author

meltingrabbit commented Mar 23, 2024 •
edited
Loading

関数にすると，型が変数にとれないので，引数の型サイズごとに関数を変えないとだめになりますね（まあ引数で型を渡す代わり，とおもえば，めんどうさは同様かもですね）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meltingrabbit meltingrabbit

Labels
priority::medium priority medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meltingrabbit @ToshiAki64