Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[combo-box] Add debounce to data requests #518

Open
rolfsmeds opened this issue Feb 11, 2021 · 3 comments
Open

[combo-box] Add debounce to data requests #518

rolfsmeds opened this issue Feb 11, 2021 · 3 comments

Comments

@rolfsmeds
Copy link
Contributor

Addresses https://github.com/vaadin/vaadin-combo-box/issues/997

@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-combo-box May 19, 2021
@web-padawan web-padawan changed the title Add debounce to data requests [combo-box] Add debounce to data requests May 20, 2021
@yuriy-fix yuriy-fix added enhancement New feature or request good first issue Good for newcomers labels Jun 22, 2021
@sissbruecker
Copy link
Contributor

It looks like the Flow component already uses a debounce of 500ms: https://github.com/vaadin/flow-components/blob/master/vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/resources/META-INF/resources/frontend/comboBoxConnector.js#L97-L99

If we want to implement a debounce in the web component, we need to remove it there and also figure out what this part is doing: https://github.com/vaadin/flow-components/blob/master/vaadin-combo-box-flow-parent/vaadin-combo-box-flow/src/main/resources/META-INF/resources/frontend/comboBoxConnector.js#L143-L150

@lanmaster
Copy link

Is there workaround to change debounce value on ComboBox?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants