Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Filters in a module #6

Open
vagnervjs opened this issue Oct 30, 2013 · 5 comments
Open

CSS Filters in a module #6

vagnervjs opened this issue Oct 30, 2013 · 5 comments
Labels

Comments

@vagnervjs
Copy link
Owner

Create a separate module for css filters.

@DanielRuf
Copy link

What about canvas filters instead of css filters? Or add a parameter which holds a value, that decides if canvas or css filters are used? Or make 2 modules, one for css filters and one for canvas filters.

Something like:

useCanvas: true //this will create canvas images from the frames and use canvas filters instead of css filters (works on more devices)

http://caniuse.com/#search=canvas

@vagnervjs
Copy link
Owner Author

I liked the idea of create 2 modules

@roman01la
Copy link

As you can see, working with canvas image data is pretty fast http://html5demos.com/gum-canvas and rendering performance somewhat similar if you apply CSS filter. But for some reason filters fails with image sequences.

But if you still going to deliver Frame Player as lib for mobile, I think you should consider to get rid of both CSS Filters and manipulations with canvas image data. Manipulation with canvas image data requires getting a snapshot of pixels data, performing some calculations with it and putting it back to canvas. It's really heavy things to do for mobile. I'd suggest to have pre-rendered image sequences, this will dramatically improve rendering performance.

There's canvas blending modes spec, which provides native Photoshop-like filtering, but I guess this is not ready for mobile yet.

@DanielRuf
Copy link

Applying the filter to image sequences should not be the problem. You just have to replace the mages with the canvas elements.

No, this is also in no official specification and is not supported by most browsers.

Generella we are now doing a clone of JSMovie http://jsmovie.burkhardt-medienproduktion.de/?page=home which is really great.

But CSS filters as module makes sense in my opinion.

@vagnervjs
Copy link
Owner Author

After a long time we have a new release using canvas element instead images.
From now on will be simple to implement a separate module of native canvas filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants