Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl script has misspelled variable name #509

Open
charlesstaats opened this issue Dec 28, 2024 · 0 comments · May be fixed by #510
Open

Perl script has misspelled variable name #509

charlesstaats opened this issue Dec 28, 2024 · 0 comments · May be fixed by #510
Assignees
Labels

Comments

@charlesstaats
Copy link
Contributor

In the perl script runtime.pl, there are two very similarly named variables: $base_source_line and $basesource_line. I'm fairly sure these were intended to be the same variable; the first is never modified after being set, while the second is modified but never used.

If you unify them, the result is a correction for certain #line directives on certain generated files. For instance, starting on line 21 of runarray.cc, the former text

#line 1 "./runtimebase.in"
#include "stack.h"
#include "types.h"
#include "builtin.h"

becomes

#line 23 "./runtimebase.in"
#include "stack.h"
#include "types.h"
#include "builtin.h"

Since #include "stack.h" is in fact line 23 of runtimebase.in (and not line 1), I think the changed version is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant