Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install breaks if cask not installed #288

Open
CalumFreeman opened this issue Jul 17, 2024 · 0 comments
Open

Install breaks if cask not installed #288

CalumFreeman opened this issue Jul 17, 2024 · 0 comments

Comments

@CalumFreeman
Copy link

Describe the bug
The readme install instructions fail if cask is not already installed

Steps to Reproduce the behaviour
Running the commands suggested in the install instructions

git clone https://github.com/vedang/pdf-tools
cd pdf-tools
make -s

gives the following error

Using Emacs 29.4
make: cask: No such file or directory
make: *** [Makefile:49: .cask/29.4] Error 127

What is the expected behaviour?
pdf-tools should install

Desktop

  • OS: Manjaro
  • Emacs Version: 29.4

Additional context

I think the solution is to install cask

git clone https://github.com/cask/cask
make -C cask install

before installing pdf-tools.

I'd suggest adding a check to the makefile to see if cask is installed, if it isn't then run the lines above which will install it. Or if that isn't trivial then update the readme to say cask needs to be installed.

(I'm still having issues with the wrong poppler version, so I can't confirm installing cask fixed things, but with cask installed make gets further than it would without)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant