Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are these Storefront templates abandoned? #93

Open
KariNarhi opened this issue Jun 20, 2024 · 2 comments
Open

Are these Storefront templates abandoned? #93

KariNarhi opened this issue Jun 20, 2024 · 2 comments

Comments

@KariNarhi
Copy link

Short explanation

I cloned the master/main branch and the template was just broken.

The template did not want to install, without using --legacy-peer-deps and even then the app did not start.

Just lots of errors about many missing variables or type errors and other critical parts being wrong.

The latest commit is 4 - 5 months old and some commits even 2 years or older.

I know that the actual Vendure API server is the main product and devs are most likely focused on that, especially now that the new version was recently released.

Suggestions and wishes

  • Jump this starter to the latest Angular version and change the Angular Universal package to the new Angular SSR.

  • Refactor from modules to standalone.

  • Implement missing/broken features or at least remove incomplete solutions and provide a base to start with.

  • Also, Karma is deprecated for testing, so I recommend trying out Jest to replace Jasmine/Karma combo.

@michaelbromley
Copy link
Member

Not abandoned but you are correct that our major focus is on the backend part, as that is our actual product.

Your suggestions are exactly aligned with mine. We would love community support with these storefronts - the scope of them does not need to grow, they basically just need some care-taking and maintenance.

@KariNarhi
Copy link
Author

FYI, in the apollo-client-provider.ts -file, in the APOLLO_CLIENT_PROVIDER -FactoryProvider's deps,
there is a [new Optional(), REQUEST] which I replaced in my updated Storefront with request from express (since nguniversal/express-engine is deprecated).

This broke my Angular Material and other functionality for some reason, so I just removed that part.
I don't even know what that [new Optional(), REQUEST] was supposed to do in the old version.

Just a little tip when someone updates the Angular-starter here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants