Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GiftCardPlugin: Compilation Error - Update 2.0.0 #22

Open
koljam opened this issue Jun 9, 2023 · 5 comments
Open

GiftCardPlugin: Compilation Error - Update 2.0.0 #22

koljam opened this issue Jun 9, 2023 · 5 comments

Comments

@koljam
Copy link
Contributor

koljam commented Jun 9, 2023

I tried updating to 2.0.0 but I get this error in the compilation step:

Error: src/extensions/gift-card-plugin/gift-card-shared.module.ts:8:5 - error TS2345: Argument of type '{ imports: (typeof SharedModule)[]; declarations: (typeof Nl2brPipe)[]; entryComponents: never[]; exports: (typeof Nl2brPipe | typeof SharedModule)[]; }' 
is not assignable to parameter of type 'NgModule'.
   Object literal may only specify known properties, and 'entryComponents' does not exist in type 'NgModule'.
 
8     entryComponents: [],
     ~~~~~~~~~~~~~~~~~~~

Is there a way to fix it myself or is this some kind of old Angular leftover?

@michaelbromley
Copy link
Member

Ah, the entryComponents module property has been removed in angular 16.

This week I am updating all the paid plugins to be fully v2 compatible (with full v2 UI makeovers) so the next version will have this solved.

@michaelbromley
Copy link
Member

Please update to v1.0.0 and let me know if it compiles now.

@koljam
Copy link
Contributor Author

koljam commented Jun 25, 2023

Works now, thank you! 👍

@koljam koljam closed this as completed Jun 25, 2023
@koljam
Copy link
Contributor Author

koljam commented Jun 25, 2023

Oh no, unfortunately, when building for prod, I get this error:
src/admin-ui/src/extensions/gift-card-plugin/gift-card-ui-lazy.module.ts(61,30): error TS7006: Parameter 'route' implicitly has an 'any' type.

@koljam koljam reopened this Jun 25, 2023
@michaelbromley
Copy link
Member

michaelbromley commented Jun 30, 2023

This is strange - the type should be inferred by TS at that location. Here's the source code in my IDE:

image

Perhaps you can work around that for now by turning off "noImplicitAny" in the tsconfig

update: actually it should already be disabled in the standard tsconfig supplied by the ui devkit: https://github.com/vendure-ecommerce/vendure/blob/c321050ae8bc80629c7f627957800190526eefaa/packages/ui-devkit/scaffold/tsconfig.json#L13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants