Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate support for the null cipher in the network protocol #47

Closed
alexrp opened this issue Jun 13, 2022 · 2 comments
Closed

Investigate support for the null cipher in the network protocol #47

alexrp opened this issue Jun 13, 2022 · 2 comments
Labels
area: net Issues related to network protocol APIs. area: research Issues related to reverse engineering of the game.
Milestone

Comments

@alexrp
Copy link
Member

alexrp commented Jun 13, 2022

Specifically, need to check whether sending 0 in the key exchange works as expected. Also check whether the client actually expects to exchange keys at all when using the null cipher.

image

@alexrp alexrp added state: approved Enhancements and tasks that have been approved. type: feature area: net Issues related to network protocol APIs. area: research Issues related to reverse engineering of the game. labels Jun 13, 2022
@alexrp alexrp added this to the v3.0 milestone Jun 13, 2022
@alexrp alexrp self-assigned this Jun 13, 2022
@alexrp alexrp modified the milestones: v3.0, v2.0 Jun 13, 2022
@alexrp
Copy link
Member Author

alexrp commented Aug 1, 2023

Further RE indicates that the client does not expect to exchange keys when using NullCipher. The socket is considered ready immediately upon receiving the CIPHER_KIND_NONE from the server.

enum CipherKind : uint32_t
{
    CIPHER_KIND_NONE = 0x0,
    CIPHER_KIND_PIKE = 0x1,
};

Should be easy enough to support.

@alexrp alexrp changed the title Investigate support for the null cipher in the network protocol and add support in Vezel.Novadrop.Net Investigate support for the null cipher in the network protocol Aug 3, 2023
@alexrp alexrp removed the state: approved Enhancements and tasks that have been approved. label Aug 3, 2023
@alexrp
Copy link
Member Author

alexrp commented Aug 3, 2023

Implementation and documentation covered by #15 and #1, respectively.

@alexrp alexrp closed this as completed Aug 3, 2023
@alexrp alexrp removed their assignment Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: net Issues related to network protocol APIs. area: research Issues related to reverse engineering of the game.
Development

No branches or pull requests

1 participant