Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking helmet upgrade #129

Closed
rchl opened this issue Jan 25, 2022 · 2 comments
Closed

Breaking helmet upgrade #129

rchl opened this issue Jan 25, 2022 · 2 comments

Comments

@rchl
Copy link

rchl commented Jan 25, 2022 •
edited
Loading

I've been using v2.0.1 which has used Helmet 4. Now that I've upgraded to v2.1.0 things broke because it's using Helmet 5 and there are breaking changes in Helmet 5.

Why was minor version of the module released with a breaking Helmet upgrade?
@rchl rchl changed the title Clean up release notes Breaking helmet upgrade Jan 25, 2022
@victor-perez
Copy link
Owner

Sorry for the inconvenience, my own upgrade to Helmet 5 went without any problems. So I assume wrongly that it was a minor version. I can't anymore remove v2.1.0 I can only make it deprecated.

@victor-perez victor-perez pinned this issue Jan 25, 2022
@rchl
Copy link
Author

rchl commented Jan 25, 2022 •
edited
Loading

Thanks.

It's good that you can't remove v2.1.0 because that would break projects in even worse way (npm install would fail).

What you should do though is you should also release 2.1.1 (or 2.2.0) that reverts helmet to version 4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rchl @victor-perez