Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunk upload errors are ignored #141

Open
vinaysshenoy opened this issue May 18, 2022 · 0 comments
Open

Chunk upload errors are ignored #141

vinaysshenoy opened this issue May 18, 2022 · 0 comments

Comments

@vinaysshenoy
Copy link

It seems like HTTP upload errors for pushing TUS chunks are being ignored.

Before this (DIFF) change, the chunk upload code was checking for both network errors as well as upload errors.

In this PR, the code was changed to delegate to a utility function to check whether the upload failed, but that function only seems to check for network errors and not HTTP upload errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vinaysshenoy