Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IllegalArgumentException w/ WrapperActivityLifecycleCallback #3

Open
skyler-stripe opened this issue Sep 23, 2021 · 0 comments · May be fixed by #4
Open

IllegalArgumentException w/ WrapperActivityLifecycleCallback #3

skyler-stripe opened this issue Sep 23, 2021 · 0 comments · May be fixed by #4

Comments

@skyler-stripe
Copy link

Hey there.

I am an engineer who works on Stripe's android sdk. We had a user using your library get an exception. You seem to have a missed nullability flag on one of your activities here.

Here's our issue if you're interested. Let me know if and how I can help.

at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3623)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3775)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2261)
at android.os.Handler.dispatchMessage(Handler.java:107)
at android.os.Looper.loop(Looper.java:237)
at android.app.ActivityThread.main(ActivityThread.java:8107)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)
Caused by: java.lang.IllegalArgumentException: Parameter specified as non-null is null: method kotlin.jvm.internal.Intrinsics.checkParameterIsNotNull, parameter bundle
at com.viniciusmo.keyboardvisibility.WrapperActivityLifecycleCallback.onActivityCreated(Unknown Source:7)
at android.app.Application.dispatchActivityCreated(Application.java:392)
at android.app.Activity.dispatchActivityCreated(Activity.java:1228)
at android.app.Activity.onCreate(Activity.java:1505)
at androidx.core.app.ComponentActivity.onCreate(ComponentActivity.java:85)
at androidx.activity.ComponentActivity.onCreate(ComponentActivity.java:314)
at androidx.fragment.app.FragmentActivity.onCreate(FragmentActivity.java:273)
at com.stripe.android.view.StripeActivity.onCreate(StripeActivity.kt:48)
at com.stripe.android.view.AddPaymentMethodActivity.onCreate(AddPaymentMethodActivity.kt:91)
at android.app.Activity.performCreate(Activity.java:7957)
at android.app.Activity.performCreate(Activity.java:7946)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1307)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3598)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3775) 
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83) 
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2261) 
at android.os.Handler.dispatchMessage(Handler.java:107) 
at android.os.Looper.loop(Looper.java:237) 
at android.app.ActivityThread.main(ActivityThread.java:8107) 
at java.lang.reflect.Method.invoke(Native Method) 
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496) 
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100) ```
BradPatras added a commit to BradPatras/keyboard-visibility-event-android that referenced this issue Sep 28, 2021
@BradPatras
Updated bundle param to be nullable
4731cbf 
The docs specify that the `Bundle` param in the onActivityCreated function is nullable, so the override definition should match. Should fix viniciusmo#3
@BradPatras BradPatras linked a pull request Sep 28, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated bundle param to be nullable BradPatras/keyboard-visibility-event-android
1 participant
@skyler-stripe