Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No data is persisted during IBD #250

Closed
JoseSK999 opened this issue Oct 7, 2024 · 2 comments · Fixed by #291
Closed

No data is persisted during IBD #250

JoseSK999 opened this issue Oct 7, 2024 · 2 comments · Fixed by #291

Comments

@JoseSK999
Copy link
Contributor

Previously indexes and headers were saved on the fly (while rn they are kept in a HashMap until calling flush), and flush was called periodically during IBD (now only after validating blocks once synced).

In other words, all the progress is lost if the node crashes during IBD. This may be faster but doesn't seem desirable.

@jaoleal
Copy link
Contributor

jaoleal commented Oct 7, 2024

Maybe we could offer a Checkpoint option and the user can set how many blocks we can "risk" until they are saved in.

in config.toml

checkpoint = 100_000 # this would make floresta wait every 100_000 blocks until stop everything and save on DB

@Davidson-Souza
Copy link
Collaborator

Yeah, this is super annoying. The reason I've stopped flushing and added the hashmap is that kv was killing performance, specially during headers sync. I hope that #251 will give us the possibility of restoring from a shutdown during IBD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants