Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception for Specific Dates #40

Open
reallyrehan opened this issue Dec 31, 2024 · 2 comments · May be fixed by #41
Open

Exception for Specific Dates #40

reallyrehan opened this issue Dec 31, 2024 · 2 comments · May be fixed by #41

Comments

@reallyrehan
Copy link

This condition fails for specific dates. For example, running for 31-December without providing start_date raises an exception

ValueError: day is out of range for month

https://github.com/virattt/ai-hedge-fund/blame/6c888162a6a9085bfd5a7061a4bc6ae21c210c51/src/agents/market_data.py#L21
@Phytonking
Copy link

I'm getting a similar issue right now. I will go deeper into the code and try to solve this.

@reallyrehan reallyrehan linked a pull request Dec 31, 2024 that will close this issue
Open
@reallyrehan
Copy link
Author

Thanks @Phytonking ! I've already added a PR with a suggested fix - can you give it a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: start-date parsing in market_data.py reallyrehan/ai-hedge-fund
2 participants
@reallyrehan @Phytonking