Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] An extra, stale frame captured at start of render #180

Open
chrisgervang opened this issue Oct 11, 2021 · 1 comment
Open

[Bug] An extra, stale frame captured at start of render #180

chrisgervang opened this issue Oct 11, 2021 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@chrisgervang
Copy link
Collaborator

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to camera example
  2. Zoom out a lot
  3. Change render to JPEG
  4. Click render
  5. Once finished, open .tar, see the 000000.jpeg is the improper zoom level and there is one more image than expected.

Expected behavior
000000.jpeg should look like the programmed frame value, not the user-controlled viewState.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Chrome

Additional context
Bug is likely caused by an extra adapter.onAfterRender call occurring before the map is redrawn to the correct keyframe values. We'll need a better way of understanding when it's time to capture the frame.

@chrisgervang chrisgervang added the bug Something isn't working label Oct 11, 2021
@chrisgervang
Copy link
Collaborator Author

@hkim8567 can you share the screenshot of 000000.jpeg zoomed out?

@chrisgervang chrisgervang added this to the 1.4 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant