Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with deck.gl and luma.gl v9 #277

Open
sraimund opened this issue Jul 4, 2024 · 1 comment
Open

Compatibility with deck.gl and luma.gl v9 #277

sraimund opened this issue Jul 4, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@sraimund
Copy link

sraimund commented Jul 4, 2024

Describe the bug/feature
I tried the pure JS example with deck.gl and luma.gl updated to their latest versions. The video rendering works, however, the background is black and artifacts appear for pixels close to the background.

Screenshot
grafik

To Reproduce

yarn install or npm install with the following package.json of examples/get-started/pure-js

{
  "name": "pure-js-basic",
  "version": "0.0.0",
  "license": "MIT",
  "private": true,
  "scripts": {
    "start": "vite --open",
    "start-local": "vite --config ../../vite.config.local.mjs",
    "build": "vite build"
  },
  "dependencies": {
    "@hubble.gl/core": "^1.3.0",
    "@deck.gl/core": "^9.0.21",
    "@deck.gl/layers": "^9.0.21",
    "popmotion": "9.3.1"
  },
  "overrides": {
    "@hubble.gl/core": {
      "@luma.gl/core": "^9.0.15",
      "@luma.gl/constants": "^9.0.15",
      "@luma.gl/engine": "^9.0.15",
      "@luma.gl/shadertools": "^9.0.15",
      "@luma.gl/webgl": "^9.0.15"
    }
  },
  "resolutions": {
    "@luma.gl/core": "^9.0.15",
    "@luma.gl/constants": "^9.0.15",
    "@luma.gl/engine": "^9.0.15",
    "@luma.gl/shadertools": "^9.0.15",
    "@luma.gl/webgl": "^9.0.15"
  },
  "devDependencies": {
    "vite": "^4.0.0"
  }
}

Expected behavior
The video rendering works similarly to the previous versions (i.e., 8) of deck.gl and luma.gl.

Desktop

  • OS: Windows 11
  • Browser: Firefox 127, Chrome 126
@sraimund sraimund added the bug Something isn't working label Jul 4, 2024
@sraimund
Copy link
Author

Changing

export const deck = new Deck({
  ...
  parameters: {
    clearColor: [255, 255, 255, 1]
  },
});

to

export const deck = new Deck({
  ...
  views: new MapView({
    clear: {
      color: [255, 255, 255, 1]
    }
  }),
});

resolves the problem since the API of deck.gl has changed from v8 to v9 (as discussed here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant