Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service Resources with non-obvious pluralization fails #190

Open
Samze opened this issue Nov 10, 2021 · 5 comments · Fixed by #230
Open

Service Resources with non-obvious pluralization fails #190

Samze opened this issue Nov 10, 2021 · 5 comments · Fixed by #230
Assignees
Labels
bug Something isn't working worked-around
Milestone

Comments

@Samze
Copy link
Contributor

Samze commented Nov 10, 2021

The service-binding controller uses this unsafe method to determine the GVR from the GVK to setup a watch dynamically. This method attempts to guess the GVR with some string checks and a lot of assumptions.

Unfortunately this Postgres Operator this fails inference of the pluralization. The plural is postgreses but just postgres.

This blocks this operator from being used with the binding operator. The only workaround is to use a direct secret reference.

cc @jpatel-pivotal


Note: Plural resource name for Postgres is postgres rather than the incorrect inferred postgreses

@Samze Samze changed the title Resources with non-obvious pluralization fails Service Resources with non-obvious pluralization fails Nov 10, 2021
@rashedkvm rashedkvm self-assigned this Nov 12, 2021
@rashedkvm rashedkvm added bug Something isn't working worked-around labels Nov 12, 2021
@rashedkvm
Copy link
Member

New dynamic rest mapper a possible way to resolve this https://pkg.go.dev/sigs.k8s.io/controller-runtime/pkg/client/apiutil#NewDynamicRESTMapper. Will test it out ASAP!

@scothis
Copy link
Contributor

scothis commented Feb 15, 2022

@rashedkvm any update on your testing?

@rashedkvm
Copy link
Member

Not yet @scothis. It is on the priority list now 😀

@scothis
Copy link
Contributor

scothis commented Mar 8, 2022

We should still fix this for real

@scothis scothis reopened this Mar 8, 2022
@rashedkvm
Copy link
Member

We will replace the tactical fix with a real fix and target for Service Bindings v0.7.2+

@atmandhol atmandhol added this to the 0.7.2 milestone Mar 11, 2022
@atmandhol atmandhol modified the milestones: 0.7.2, 0.7.3 Jun 8, 2022
@atmandhol atmandhol modified the milestones: 0.9.0, 0.10.0 Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working worked-around
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants