[gog] 'gog failed: Cannot read properties of null (reading '1')'

[shinji257]

No description provided.

[FluffyClaws]

Did you know that the more info on an issue is provided the more easily it is to locate and fix?

Nevertheless, I did encounter the same error, BUT, after running the script the second time after claiming the game.

Full error looks like following:

TypeError: Cannot read properties of null (reading '1')
    at file:///free-games-claimer/gog.js:102:62

So I would assume the issue is that on the consecutive runs the matching text is not found returning null, and attempting to access [1] on the null value.

const title = text.match(/Claim (.*) and don't miss the/)[1];

I`ve never encountered this before personally, and I run the script twice each time, so most likely the are some changes on the GoG website that have caused this. Not sure how to test without a giveaway though.

[vinnymac]

I can confirm this happens after there are no more games to claim, so likely a change on the site occurred. If a game is available to claim it works just fine.

[jordyamc]

I changed it to this to fix this error

- const title = text.match(/Claim (.*) and don't miss the/)[1];
+ const match_all = text.match(/Claim (.*) and don't miss the|Success! (.*) was added to/);
+ const title = match_all[1] ? match_all[1] : match_all[2];

[silkyclouds]

Can we eventually get a fix in the docker image based on @jordyamc comment ? I'm getting this error message as well and would like to get rid of it.
'gog failed: Cannot read properties of null (reading '1')'

[NeoMod]

@jordyamc Thank you! 👍

[depau]

I changed it to this to fix this error

- const title = text.match(/Claim (.*) and don't miss the/)[1];
+ const match_all = text.match(/Claim (.*) and don't miss the|Success! (.*) was added to/);
+ const title = match_all[1] ? match_all[1] : match_all[2];

@jordyamc
Can you please submit a pull request?

[AgentTechnoman]

@depau
#411

Edit: Log output from container a including @jordyamc fix:

[+] Running 1/0
 ✔ Container FreeGamesClaimer  Created
Attaching to FreeGamesClaimer
FreeGamesClaimer  | Version: https://github.com/vogler/free-games-claimer/tree/
FreeGamesClaimer  | Build:
FreeGamesClaimer  | Xvfb display server created screen with resolution 1920x1080
FreeGamesClaimer  | VNC is running on port 5900 (no password!)
FreeGamesClaimer  | noVNC (VNC via browser) is running on http://localhost:6080
FreeGamesClaimer  |
FreeGamesClaimer  | 2024-12-19 23:52:38.747 started checking epic-games
FreeGamesClaimer  | Adding webgl.disabled to /fgc/data/browser/prefs.js
FreeGamesClaimer  | Signed in as **************
FreeGamesClaimer  | Free games: [ 'https://store.epicgames.com/en-US/p/vampire-survivors-f699a1' ]
FreeGamesClaimer  | Current free game: Vampire Survivors
FreeGamesClaimer  |   Already in library! Nothing to claim.
FreeGamesClaimer  | 2024-12-19 23:52:57.338 started checking prime-gaming
FreeGamesClaimer  | Signed in as **************
FreeGamesClaimer  | waitUntilStable 6671
FreeGamesClaimer  | waitUntilStable 6723
FreeGamesClaimer  | waitUntilStable 6721
FreeGamesClaimer  | waitUntilStable 6721
FreeGamesClaimer  | Number of already claimed games (total): 63
FreeGamesClaimer  | Number of free unclaimed games (Prime Gaming): 0
FreeGamesClaimer  | Number of free unclaimed games (external stores): 0
FreeGamesClaimer  | 2024-12-19 23:53:27.734 started checking gog
FreeGamesClaimer  | Signed in as **************
FreeGamesClaimer  | Current free game: Chicken Assassin: Reloaded - https://www.gog.com/en/game/chicken_assassin_reloaded
FreeGamesClaimer  |   Already in library! Nothing to claim.
FreeGamesClaimer exited with code 0