From b0516d73f3b2b2ab1f66ffbccb530df1c1b61df1 Mon Sep 17 00:00:00 2001 From: Duc Trung Le Date: Tue, 15 Oct 2024 00:00:34 +0200 Subject: [PATCH] Fix CI --- .github/workflows/main.yml | 2 +- .github/workflows/ui-tests.yml | 16 ++++++++-------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index a686d40ea..3b29ee5d1 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -74,7 +74,7 @@ jobs: strategy: fail-fast: false matrix: - os: [macos] + os: [macos-12] python_version: ['3.8', '3.9', '3.10', '3.11'] steps: diff --git a/.github/workflows/ui-tests.yml b/.github/workflows/ui-tests.yml index 08d8ddd24..aa27f2344 100644 --- a/.github/workflows/ui-tests.yml +++ b/.github/workflows/ui-tests.yml @@ -12,10 +12,10 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - jupyter-server-version: ["1.24.0", "2.14.2"] + jupyter-server-version: ['1.24.0', '2.14.2'] progressive_rendering: [false, true] exclude: - - jupyter-server-version: "1.24.0" + - jupyter-server-version: '1.24.0' progressive_rendering: true fail-fast: false @@ -61,16 +61,16 @@ jobs: - name: Set test report name for progressive rendering if: always() && matrix.progressive_rendering == true run: | - echo "TEST_REPORT_NAME=progressive-voila-test-report" >> $GITHUB_ENV - echo "TEST_ASSETS_NAME=progressive-voila-test-assets" >> $GITHUB_ENV - echo "TEST_BENCHMARK_NAME=progressive-voila-test-benchmark" >> $GITHUB_ENV + echo "TEST_REPORT_NAME=progressive-voila-test-report-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV + echo "TEST_ASSETS_NAME=progressive-voila-test-assets-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV + echo "TEST_BENCHMARK_NAME=progressive-voila-test-benchmark-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV - name: Set test report name for non-progressive rendering if: always() && matrix.progressive_rendering == false run: | - echo "TEST_REPORT_NAME=voila-test-report" >> $GITHUB_ENV - echo "TEST_ASSETS_NAME=voila-test-assets" >> $GITHUB_ENV - echo "TEST_BENCHMARK_NAME=voila-test-benchmark" >> $GITHUB_ENV + echo "TEST_REPORT_NAME=voila-test-report-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV + echo "TEST_ASSETS_NAME=voila-test-assets-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV + echo "TEST_BENCHMARK_NAME=voila-test-benchmark-${{ matrix.jupyter-server-version }}" >> $GITHUB_ENV - name: Upload Playwright Test assets if: always()