Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Video Attributes #95

Open
benjaminpkane opened this issue Mar 5, 2020 · 5 comments
Open

Support for Video Attributes #95

benjaminpkane opened this issue Mar 5, 2020 · 5 comments
Labels
feature Work on a feature request

Comments

@benjaminpkane
Copy link
Contributor

Not blocking anything, but it would be nice to have soon.

@benjaminpkane benjaminpkane added the feature Work on a feature request label Mar 5, 2020
@lethosor
Copy link
Contributor

lethosor commented Mar 5, 2020

I can look into it if you have labels with video-level attrs laying around. Shouldn't be too complicated to add.

@brimoor
Copy link
Contributor

brimoor commented Mar 5, 2020

@lethosor this touches on the notion of "rendering VideoLabels at the frame-level" that I mentioned previously.

The way to support this would be to implement the render() method here: https://github.com/voxel51/eta/blob/0096e7983d01e87d6d88bb8f8cf193fbb5cfbbf1/eta/core/video.py#L1396

Let's chat when time permits.

@lethosor
Copy link
Contributor

lethosor commented Mar 5, 2020

Player51 isn't structured the same way as ETA (i.e. there's no real equivalent to the render method you're referring to), but I was thinking of essentially treating video attributes as frame-level attributes present on every frame. There are a couple places where I think that could be done cleanly/easily.

@brimoor
Copy link
Contributor

brimoor commented Mar 5, 2020

I know that Player51 isn't structured the same way. I'm basically saying that, once you see what new VideoLabels can support, you will likely want a render method.

Video attributes are simple enough to hack by copying on every frame, yes. That's what the render() method I pointed to does, as well.

@benjaminpkane
Copy link
Contributor Author

#94 has a new attrs.html test with video, frame, and object attributes of all three types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on a feature request
Projects
None yet
Development

No branches or pull requests

3 participants